Fix Spectate command #422
Open
Fix Spectate command #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While probably not a necessary command to reimplement into Folia, it should probably be implemented for more Vanilla parity and such. The fix introduced here essentially schedules the full method in a very similar way as the other command patches. The `ServerPlayer#setCamera` method is already patched to support off-region targets, so we schedule the method contents to the `ServerPlayer` spectator. Ive tested this via the command below: ``` /spectate @e[limit=1,type=!player,sort=random] Dueris ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While probably not a necessary command to reimplement into Folia, it should probably be implemented for more Vanilla parity and such.
The fix introduced here essentially schedules the full method in a very similar way as the other command patches. The
ServerPlayer#setCameramethod is already patched to support off-region targets, so we schedule the method contents to theServerPlayerspectator.Ive tested this via the command below: