chore: support esm + cjs #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for shipping the PR! |
P0lip
approved these changes
Feb 4, 2025
Owner
|
Thanks again for the PR. I'll have it released this week. |
Contributor
Author
|
Thanks @P0lip! |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jakub, I have been evaluating JSONPath libraries to replace the old
jsonpathNPM package I am using now. I knew about Nimma from a while back but I was excited to see you are implementing an RFC9535 successor. One issue I encountered is that the package is built as ESM-only which is super refreshing. Sadly I do need to support CommonJS users (I hope not for long...). I was wondering if you'd be interested in a PR to add dual bundling support. I don't have an immediate need for this and I'm happy to close the draft PR if it's creating noise or straight up an unwanted "feature" (if you could call cjs that).