ENG-194 // Fix df.size() in python

[Lilianxr]

We don't have any partial/queried df view provided in python. So it's safe to just return the total_entries of the df for .size() instead of the view height

linear: https://linear.app/oxenai/issue/ENG-194/python-remote-data-frame-size-is-page-size-not-data-frame-size

[coderabbitai]

Walkthrough

The PyWorkspaceDataFrame::size method's height calculation was modified to derive the row count from df.view.pagination.total_entries instead of size.height.

Changes

Cohort / File(s)	Summary
Height calculation update oxen-python/src/py_workspace_data_frame.rs	Modified PyWorkspaceDataFrame::size method to compute height using pagination metadata (df.view.pagination.total_entries) rather than size.height

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

• Single file with localized change to one method
• Straightforward field access replacement
• No new logic patterns introduced; verify pagination metadata availability and correctness

Poem

🐰 A frame once measured by height divine,
Now counts by pagination's line,
Total entries bloom where size once grew,
The workspace dances, fresh and new! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ENG-194 // Fix df.size() in python' directly describes the main change: fixing the df.size() method in the Python codebase.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/df-size

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dd5b81 and c8ee42b.

📒 Files selected for processing (1)

• oxen-python/src/py_workspace_data_frame.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Test Suite / Test Suite (macos-latest)
• GitHub Check: Test Suite / Test Suite (windows-latest)
• GitHub Check: Test Suite / Test Suite (ubuntu-latest)

🔇 Additional comments (1)

oxen-python/src/py_workspace_data_frame.rs (1)

108-115: The change from size.height to df.view.pagination.total_entries is correct.

The field pagination.total_entries is properly typed as usize and represents the total row count across all pages, which aligns with the expected behavior of the size() method as evidenced by Python test usage.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}