-
-
Notifications
You must be signed in to change notification settings - Fork 3
Include Orama Search! #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughEnvironment variable management was enhanced across the project. The Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Build Step
participant Environment
participant Docusaurus
GitHub Actions->>Build Step: Trigger build/deploy workflow
Build Step->>Environment: Set env vars from secrets (.env or GitHub secrets)
Build Step->>Docusaurus: Run npm build (with env vars)
Docusaurus->>Docusaurus: Load env vars via dotenv
Docusaurus->>Docusaurus: Initialize @orama/plugin-docusaurus-v3 with env vars
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
30-30: Fix trailing whitespace.Static analysis detected trailing spaces on this line.
- +🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 30-30: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (5)
.github/workflows/ci.yml(1 hunks).github/workflows/deploy.yml(1 hunks).gitignore(1 hunks)docusaurus.config.js(5 hunks)package.json(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/ci.yml
[error] 30-30: trailing spaces
(trailing-spaces)
🔇 Additional comments (5)
.gitignore (1)
13-13: Good security practice!Adding
.envto gitignore is essential to prevent accidentally committing sensitive environment variables like the Orama API keys used in this project..github/workflows/ci.yml (1)
26-29: Environment variable configuration looks good.Properly configuring Orama secrets as environment variables during the build step ensures the plugin can access necessary credentials while maintaining security through GitHub secrets.
.github/workflows/deploy.yml (1)
26-29: Consistent and secure environment variable configuration.The deployment workflow correctly mirrors the CI workflow's environment variable setup, ensuring the Orama plugin has access to necessary credentials during site deployment.
docusaurus.config.js (2)
1-1: Proper environment variable loading.Adding dotenv configuration enables loading environment variables from
.envfiles, which is essential for local development of the Orama integration.
79-82: Minor formatting improvements applied.The spacing and formatting adjustments improve code consistency throughout the configuration file.
Also applies to: 90-90, 100-102
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Preview
Summary by CodeRabbit