Integrate gtfstidy into the bundler and oba images #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates gtfstidy into the bundler and oba images to streamline GTFS processing as part of the build process.
- Added the GTFS_TIDY_ARGS environment variable in the Docker compose configuration to enable gtfstidy configuration.
- Updated the README by removing an outdated note regarding Maven artifacts for the app server build.
Reviewed Changes
Copilot reviewed 2 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.standalone.yml | Added GTFS_TIDY_ARGS to configure gtfstidy for image generation. |
| README.md | Removed outdated instructions related to Maven authentication. |
Files not reviewed (7)
- bundler/Dockerfile: Language not supported
- bundler/build_bundle.sh: Language not supported
- bundler/set_goarch.sh: Language not supported
- oba/Dockerfile: Language not supported
- oba/bootstrap.sh: Language not supported
- oba/build_bundle.sh: Language not supported
- oba/set_goarch.sh: Language not supported
Comments suppressed due to low confidence (1)
docker-compose.standalone.yml:47
- Please verify that 'v' is the intended value for GTFS_TIDY_ARGS. If a more descriptive flag is preferred, updating this value could improve clarity and prevent misconfiguration.
- GTFS_TIDY_ARGS=v
aaronbrethorst
force-pushed
the
gtfstidy
branch
from
76d1dc4 to
543ee57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #115