PhasorDynamics simulations with sparse Jacobians #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkoukpaizan
added
enhancement
nkoukpaizan
force-pushed
the
nicholson/sim-with-sparse-jac
branch
2 times, most recently
from
f80e836 to
8a6ddd0
Compare
nkoukpaizan
force-pushed
the
nicholson/sim-with-sparse-jac
branch
4 times, most recently
from
05e2ddb to
3285026
Compare
nkoukpaizan
requested review from
PhilipFackler,
abirchfield,
alexander-novo,
lukelowry and
pelesh
pelesh
reviewed
Jan 8, 2026
Comment on lines
+181
to
+182
| sys.evaluateResidual(); | ||
| sys.evaluateJacobian(); |
Collaborator
There was a problem hiding this comment.
These calls should not be made here. Evaluating residual and Jacobian should be done by the numerical integrator only, not a user code.
Suggested change
| sys.evaluateResidual(); | |
| sys.evaluateJacobian(); |
Comment on lines
+99
to
+101
| sys.initialize(); | ||
| sys.evaluateResidual(); | ||
| sys.evaluateJacobian(); |
Collaborator
There was a problem hiding this comment.
Since this is a workaround we should either hide these lines in SystemModel or comment them as temporary.
Comment on lines
+79
to
+81
| sys.initialize(); | ||
| sys.evaluateResidual(); | ||
| sys.evaluateJacobian(); |
Collaborator
There was a problem hiding this comment.
See earlier comments. Allocating and initializing system here is ok but evaluating residual and Jacobian may be confusing for the user.
nkoukpaizan
force-pushed
the
nicholson/sim-with-sparse-jac
branch
from
0a47f42 to
ad67082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ability to run
PhasorDynamicsexamples with sparse Jacobian. The component Jacobians are obtained with Enzyme and assembled into the system Jacobian.cc @lukelowry @abirchfield
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
This is still using
COO_Matrix. I suggest we merge #307 and re-use Jacobian assembly.Comparison plots between current (sparse Jacobians) and reference (dense Jacobians computed by IDA with finite differences)
ThreeBus_Basic
ThreeBus_Classical
TenGenGenrou
TenGenGenClassical
