Fixes #28055: Migrate SettingsApi to zio-json #6818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Commit modified |
clarktsiory
force-pushed
the
arch_28055/migrate_settingsapi_to_zio_json
branch
from
714ffc1 to
be06578
Compare
clarktsiory
force-pushed
the
arch_28055/migrate_settingsapi_to_zio_json
branch
from
be06578 to
ee5dabf
Compare
Contributor
Author
|
Commit modified |
clarktsiory
force-pushed
the
arch_28055/migrate_settingsapi_to_zio_json
branch
from
ee5dabf to
9783872
Compare
Contributor
Author
|
Commit modified |
Contributor
Author
|
PR updated with a new commit |
2 similar comments
Contributor
Author
|
PR updated with a new commit |
Contributor
Author
|
PR updated with a new commit |
P4uline
reviewed
Jan 5, 2026
P4uline
approved these changes
Jan 5, 2026
Contributor
|
This PR is not mergeable to upper versions. |
Contributor
Author
|
OK, squash merging this PR |
clarktsiory
force-pushed
the
arch_28055/migrate_settingsapi_to_zio_json
branch
from
7ead784 to
f0b9a5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/28055
This PR removes the lift-json import from
SettingsApi.scala.It :
toJsonandparseJsonmethod of each setting by an idiomatic "JsonCodecinstance" in zio-json➡️ the main change is about adding
given JsonCodec[...]in place of lift-json. In some places, we need to use the JSON AST types since the settings are implemented in a generic wayAlong the way :
BoxwithEitherimplicitwithgivenEDIT: there is another change, to avoid referencing settings key as hardcoded String, it's possible to extract settings implementation (using ZLayer) and make each setting be an enum