Fixes #27873: Rudder package should always clean the /opt/rudder/share/plugins/<plugin id> folder before unpacking a plugin #6712
+46
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/plugins/<plugin id> folder before unpacking a plugin
…er/share/plugins/<plugin id> folder before unpacking a plugin Fixes #27873: Rudder package should always clean the /opt/rudder/share/plugins/<plugin id> folder before unpacking a plugin
Contributor
Author
|
PR updated with a new commit |
amousset
reviewed
Nov 28, 2025
|
|
||
| fn get_default_package_scripts_extract_folder(&self) -> Result<PathBuf> { | ||
| let safe_name_pattern = Regex::new(r"^[a-zA-Z0-9\-_]+$")?; | ||
| if safe_name_pattern.is_match(&self.metadata.name) { |
Member
There was a problem hiding this comment.
we should probably ensure safe names in the metadata constructors, likely with a dedicated type enforcing these constraints
Member
There was a problem hiding this comment.
A bit like we do for Condition in rudderc (with only a stirng inside obviously), with specific Deserializer
amousset
reviewed
Nov 28, 2025
|
|
||
| if is_upgrade { | ||
| // First uninstall old version, but without running prerm/portrm scripts | ||
| db.uninstall(&self.metadata.name, false, webapp)?; |
Member
There was a problem hiding this comment.
shouldn't the cleanup be done by the uninstall step instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/27873