Implement DiffEqBase.anyeltypedual for GraphDynamics types
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR #32 somehow broke a couple things in the Neuroblox.jl docs building pipeline due to how it interacted with the GraphDynamics tutorial. This change (which is good to do anyways) should fix that breakage. It basically just helps the differential equation solvers tell if anything in the problem is a dual number. I also did a little cleanup of unwanted stuff, and implemented a couple SymbolicIndexingInterface methods for `Num`s with observed variables.
Collaborator
Author
|
Sidenote, it turns out that the breakage wasn't from #32, that actually broke earlier as can be seen in the CI logs for https://github.com/Neuroblox/Neuroblox.jl/pull/599. I'm guessing there was some upstream change in how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #32 somehow broke a couple things in the Neuroblox.jl docs building pipeline due to how it interacted with the GraphDynamics tutorial. This change (which is good to do anyways) should fix that breakage. It basically just helps the differential equation solvers tell if anything in the problem is a dual number.
I also did a little cleanup of unwanted clutter, and implemented a couple SymbolicIndexingInterface methods for
Nums with observed variables.