perf(isCheckedOut): use entrySet to iterate Map and improve performance #8723
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The change to using an entry set may be a minor improvement, but is one not likely to be noticeable when running the application. There are other commits in this PR the correctness of which I cannot validate. If the change of name usage in the XCoffSymbol fixes a bug, then that is the more important part of this PR. |
jobermayr
reviewed
Dec 3, 2025
| import org.jdom.input.SAXBuilder; | ||
| import org.jdom.output.XMLOutputter; | ||
|
|
||
| import ghidra.formats.gfilesystem.LocalFileSystem; |
Contributor
There was a problem hiding this comment.
This leads to a build error and is not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor isCheckedOut to use entrySet instead of keySet when iterating the Map.
This avoids unnecessary get() calls for each key, improving performance
while keeping the method behavior unchanged.