Skip to content

Conversation

@f-hafner
Copy link
Contributor

Description

This proposes a fix to #372.

I just now realise #373 asks for a workflow. I had also wondered whether I should add that. For now, it's just in the sample code in the README.dev.md file. I can transfer this into a workflow file -- can you give some feedback on the sample code? I copied from a workflow that works, but perhaps you have suggestions for improvement.

@f-hafner f-hafner requested a review from egpbos March 21, 2024 10:50
@f-hafner
Copy link
Contributor Author

f-hafner commented Mar 22, 2024

@fdiblen
Copy link
Member

fdiblen commented Aug 27, 2024

Hey @f-hafner ,

The template is using copier now. Will you have time to update and complete this PR?

@f-hafner
Copy link
Contributor Author

@fdiblen , I have to get familiar with the new template but I can work on this

@fdiblen
Copy link
Member

fdiblen commented Sep 16, 2024

@fdiblen , I have to get familiar with the new template but I can work on this

I think it makes more sense to close this pull request and create a new one. I will close this PR. Please let us know if you need help with creating a new one.

@fdiblen fdiblen closed this Sep 16, 2024
@egpbos
Copy link
Collaborator

egpbos commented Sep 18, 2024

Was it really necessary to close this? It seemed like the merge conflicts were minor, especially because one file is completely new.

@egpbos egpbos reopened this Sep 18, 2024
@JaroCamphuijsen
Copy link
Member

@f-hafner @fdiblen I was working with a project based on the template today and was really surprised the automated PyPI publishing workflow is not yet in there, is it ok if I pick this up and add the workflow file to the template? The current 3-step manual release instructions feel quite outdated.

@fdiblen
Copy link
Member

fdiblen commented Jan 13, 2026

Hi @JaroCamphuijsen

I am not actively working on this project anymore and not up to date with the recent changes. But, I would be careful about complete automation as users may need to take a few more steps such as check Zenodo integration, test the package etc.

@sverhoeven and @abelsiqueira may help you deciding the best way forward.

@egpbos egpbos removed their request for review January 13, 2026 14:04
@abelsiqueira
Copy link
Member

I like the idea, and I think @f-hafner won't mind if you take it over, but I haven't been working on the Python template.
I know @sjvrijn was spending some time maintaining it, so he has a better view of where it is going at the moment.
That said, I think it fits in the template because you can make auto-publishing to pypi optional and not part of the default recommendation in copier.

@sjvrijn
Copy link
Contributor

sjvrijn commented Jan 13, 2026

@JaroCamphuijsen Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants