-
Notifications
You must be signed in to change notification settings - Fork 1
[PRMP-1283] Update Authoriser and Endpoint Logic to Support Placeholder NHS Number Access #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
steph-torres-nhs
wants to merge
11
commits into
main
Choose a base branch
from
PRMP-1283
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NogaNHS
reviewed
Jan 15, 2026
NogaNHS
approved these changes
Jan 16, 2026
Code security issues foundView full details here. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Overview
Jira ticket: TBC
Description
Add a check against placeholder NHS Number check in the Authoriser
Ensure custodian check in GET and PATCH DocumentReview/{id}/{version}
Context
As a Reviewer, I want to be able to access and review records associated with the placeholder NHS number (0000000000) if I am the custodian So that I can correct or process records where the patient was initially unknown without being blocked by standard NHS number scope validation.
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)[ ] 4. I have updated relevant documentation.Deploy - Sandbox- workflow run mainSANDBOX Full- Deploy feature branch to sandbox- workflow run - TBC