Align with upstream changes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support for gradle 3.+ * Support for RN 0.56.+
RN 0.57 requires gradle 3, which in turn requires certain build tools and sdk versions
Use project-wide properties and new dependency
* Update README.md
* Update README.md * Update README.md
* fix react-native 0.58 build error * version bumped up from 1.0.0 to 1.0.1
if hardware buttons are enabled (and software are disabled) return 0 instead of still returning the height of the software menu buttons
The result of display calculations may come back as floats. This is okay. They're calculations based on dpi and height/width, not actual pixel counts
Each constant is not accessible through a function. This should make autocomplete within IDE's much easier
Appreciate it!
Unifies interface on all platforms Module syntax for potential tree shaking
…#51) * Fixed build issue * Fixed hasPermanentMenuKey() returning the wrong value * Cleaned up code slightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #1