Skip CP change emails for users who have withdrawn all forecasts #3976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending "Significant change" (CP change) emails, skip users who have withdrawn their predictions from ALL questions in a post. - Add helper function get_users_with_active_forecasts_for_questions() that returns user IDs with at least one active forecast - Modify notify_post_cp_change() to skip users without active forecasts - Add tests for the new functionality 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
palcu
force-pushed
the
skip-cp-change-emails-for-withdrawn-forecasts
branch
from
dd1dd83 to
108e616
Compare
Contributor
Author
|
From the logs of the integration tests:
I don't think that's me... |
hlbmtc
reviewed
Dec 29, 2025
Comment on lines
+150
to
+155
| Forecast.objects.filter( | ||
| question_id__in=question_ids, | ||
| ) | ||
| .filter(Q(end_time__isnull=True) | Q(end_time__gt=timezone.now())) | ||
| .values_list("author_id", flat=True) | ||
| .distinct() |
Contributor
There was a problem hiding this comment.
@claude Reuse Forecast.objects.active() of ForecastQuerySet
Contributor
Thank you. This was an old issue with integration tests on PRs from forks (GitHub <> secrets <> forks) that I’ve just fixed — #3983. Could you please pull the latest changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
get_users_with_active_forecasts_for_questions()that returns user IDs with at least one active forecast (whereend_timeis NULL or in the future)notify_post_cp_change()to skip users without active forecastsTest plan
get_users_with_active_forecasts_for_questions()🤖 Generated with Claude Code