-
Notifications
You must be signed in to change notification settings - Fork 24
Feat/3824/bulletin/post and project #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lsabor
wants to merge
4
commits into
main
Choose a base branch
from
feat/3824/bulletin/post-and-project
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ce9702a
add post and project fields to Bulletin
lsabor 7be3982
update admin and add blank=true
lsabor 83733e2
add post_id and project_id arguments to get_bulletins view
lsabor 6ae1440
get post_id or project_slug from url in order to fetch relevant bulle…
lsabor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Generated by Django 5.1.13 on 2025-11-22 16:04 | ||
|
|
||
| import django.db.models.deletion | ||
| from django.db import migrations, models | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ("misc", "0006_whitelistuser_notes_and_more"), | ||
| ("posts", "0025_post_actual_resolve_time"), | ||
| ("projects", "0021_projectindex_project_index_projectindexpost"), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name="bulletin", | ||
| name="post", | ||
| field=models.ForeignKey( | ||
| blank=True, | ||
| help_text="Optional. If set, places this Bulletin only on this post's page.", | ||
| null=True, | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| to="posts.post", | ||
| ), | ||
| ), | ||
| migrations.AddField( | ||
| model_name="bulletin", | ||
| name="project", | ||
| field=models.ForeignKey( | ||
| blank=True, | ||
| help_text="Optional. If set, places this Bulletin only on this project's page.", | ||
| null=True, | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| to="projects.project", | ||
| ), | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a cleaner way to do this? @ncarazon
I need the post_id or project_slug
This just reads from the URL and uses regex. Maybe we have a helper or a better way to grab the relevant post or project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not totally sure we already have a helper for this
Given that, I’d keep the regex logic but extract it into a small helper under
utils/navigation.ts(e.g. getBulletinParamsFromPathname(pathname)), and then just call that from here.