-
Notifications
You must be signed in to change notification settings - Fork 56
C224 adjoint tests in jelf #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tom-j-h
wants to merge
72
commits into
MetOffice:main
Choose a base branch
from
tom-j-h:jelf_C224_adjoint_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…j-h/lfric_apps into align_adjoint_tests_to_linear_model
…test_tolerance_nml
…ted. Need to do jedi_tlm_forecast_tl
…test_tolerance_nml
…tests_to_linear_model
…test_tolerance_nml
…tests_to_linear_model
…increment_adjoint_test
…test_tolerance_nml
…tests_to_linear_model
…increment_adjoint_test
…increment_adjoint_test
…test_tolerance_nml
…tests_to_linear_model
…increment_adjoint_test
…tests_to_linear_model
…increment_adjoint_test
…test_tolerance_nml
…tests_to_linear_model
…increment_adjoint_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @mo-joshuacolclough
Code Reviewer: @jennyhickson
For testing operational TLM/adjoint configuration. There is also a test with solver settings that mean the solver runs closer to convergence, and another test initialised from a realistic increment rather than random data. A new
lfric_atmtask is added to generate this realistic increment, analogous to the existing C12 task. A script to convert the output of thelfric_atmtask to a file suitable to use for thejedi_tlm_teststask is added, again analogous to the existing C12 task. I've put these files in the locations in my$DATADIRthat you can see in the diff - but these will need to be added toBIG_DATA_DIRas part of this change.PLEASE NOTE - this is a follow-on to #161. The branch was created from #161's branch in my fork, but I can't make a PR into that branch because then I would be stuck in my fork. So, to look at the actual changes relevant to this PR alone, look at the diff of this branch with #161's branch: tom-j-h/lfric_apps@jelf_real_increment_adjoint_test...tom-j-h:lfric_apps:jelf_C224_adjoint_tests
PLEASE ALSO NOTE - #161 is blocked by #156 which relies on MetOffice/lfric_core#227, so when testing, I used this Core branch.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - jelf_C224_adjoint_tests-developer/run1
Suite Information
Task Information
✅ succeeded tasks - 1112
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review