Skip to content

Conversation

@tom-j-h
Copy link
Contributor

@tom-j-h tom-j-h commented Jan 20, 2026

PR Summary

Sci/Tech Reviewer: @mo-joshuacolclough
Code Reviewer: @jennyhickson

For testing operational TLM/adjoint configuration. There is also a test with solver settings that mean the solver runs closer to convergence, and another test initialised from a realistic increment rather than random data. A new lfric_atm task is added to generate this realistic increment, analogous to the existing C12 task. A script to convert the output of the lfric_atm task to a file suitable to use for the jedi_tlm_tests task is added, again analogous to the existing C12 task. I've put these files in the locations in my $DATADIR that you can see in the diff - but these will need to be added to BIG_DATA_DIR as part of this change.

PLEASE NOTE - this is a follow-on to #161. The branch was created from #161's branch in my fork, but I can't make a PR into that branch because then I would be stuck in my fork. So, to look at the actual changes relevant to this PR alone, look at the diff of this branch with #161's branch: tom-j-h/lfric_apps@jelf_real_increment_adjoint_test...tom-j-h:lfric_apps:jelf_C224_adjoint_tests

PLEASE ALSO NOTE - #161 is blocked by #156 which relies on MetOffice/lfric_core#227, so when testing, I used this Core branch.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - jelf_C224_adjoint_tests-developer/run1

Suite Information

Item Value
Suite Name jelf_C224_adjoint_tests-developer/run1
Suite User tom.hill
Workflow Start 2026-01-22T11:33:44
Groups Run developer
Dependency Reference Main Like
casim MetOffice/[email protected] True
jules MetOffice/[email protected] True
lfric_apps tom-j-h/lfric_apps@tlad_boundary_layer False
lfric_core tom-j-h/lfric_core@2a67d6b True
moci MetOffice/[email protected] True
SimSys_Scripts MetOffice/[email protected] True
socrates MetOffice/[email protected] True
socrates-spectral MetOffice/[email protected] True
ukca MetOffice/[email protected] True

Task Information

✅ succeeded tasks - 1112

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

tom-j-h and others added 30 commits January 7, 2026 10:23
…j-h/lfric_apps into align_adjoint_tests_to_linear_model
tom-j-h and others added 28 commits January 27, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C224 adjoint tests in jelf

3 participants