-
Notifications
You must be signed in to change notification settings - Fork 53
Updates for xcode 26 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Updates for xcode 26 #160
Conversation
Compare to OmniKitWhen comparing to OmniKit, because I was planning to make similar changes there, I noted that all but one Perhaps those lines should just be deleted instead of modified. I did a test build where I removed them from OmniBLE and every screen that used them, worked as expected. |
UpdatesI switched to using claude instead of the free gpt in Xcode. I reverted the original QoS inversion (from GPT) and replaced it with what I believe is a better fix. See: commit 5215187 |
itsmojo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with using DispatchGroup along with group.{enter,leave,wait}, so I cannot evaluate those changes other than to say it appears reasonable. I would defer to Pete for his thoughts the func store() changes. All the other changes look good to me.
This PR now just fixes the one error associated with the Test Suite using Xcode 26.2. |
Edit to explain the purpose of this PR:
Purpose
The test for OmniBLE Test suite fails when run using Xcode 26.2.
OmniBLETests/Driver/Comm/message/MessagePacketTests.swiftline 52.After fixing that error, I decided to try removing some warnings.
After some back and forth with Pete and Joe - we decided to fix just the one error in this PR.
Warnings Ignored
The hang risk graphic is shown below.
The warnings displayed for OmniBLE are shown in the screenshot below. These are ignored for the PR.
UI bug is Trio and SE phone only
I thought changing the animations lines fixed a UI bug, but (1) it did not affect the bug and (2) the bug is only seen with Trio on an SE phone running iOS 26.
Original comments below
Use GPT embedded in Xcode 26.2 to assist in fixing a test error (new with Xcode 26.2) and removing warnings.
Test
Comments
See this comment, after I switched to using claude, instead: #160 (comment)
The QoS inversion is improved but not fixed.GPT says of the accepted change:> This reduces the window for QoS inversion while preserving the existing control flow (callers still get a boolean indicating whether storage succeeded). If timeouts show up in logs, it’s a signal to consider a larger refactor to make this storage fully asynchronous with respect to session control flow.GPT suggests further modifications which were not requested> If you want, I can also:> • Plumb an asynchronous completion through store(doses:in:) so callers don’t need to block at all.> • Evaluate the pumpDelegate queue QoS configuration to align with the session queue and eliminate the inversion at the source.