Skip to content

Conversation

@cnathe
Copy link
Contributor

@cnathe cnathe commented Nov 29, 2024

Rationale

See related PR for rationale. This PR just fixes the misc test failures that are now erroring out because the deprecated look and feel setting is no longer present on the page.

Related Pull Requests

Changes

  • Use findElementOrNull for look and feel settings that are now deprecated

@labkey-adam
Copy link
Contributor

@cnathe thanks... I created #2160 yesterday for this. Maybe we go with that one since it fixes the test as well?

@cnathe
Copy link
Contributor Author

cnathe commented Nov 29, 2024

@cnathe thanks... I created #2160 yesterday for this. Maybe we go with that one since it fixes the test as well?

Perfect, @labkey-adam. Yes let's go with that one. I'll close this PR.

@cnathe cnathe closed this Nov 29, 2024
@cnathe cnathe removed the request for review from labkey-tchad November 29, 2024 22:44
@labkey-tchad labkey-tchad deleted the fb_optionalDateParsingTestFix branch December 2, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants