Merge build error context into stdout/stderr columns #3382
Merged
+95
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDash currently maintains two separate types of build errors: "build errors", which are scraped from the log, and "build failures" which are collected by launchers. Needing (almost) duplicate logic to handle these two cases is a major pain point throughout the codebase. This commit begins the process of merging errors and failures into a single table by migrating the precontext, text, and postcontext columns of the builderror table to a stdoutput column which contains precontext+text+postcontext, and a stderror column which contains just the error text.
williamjallen
force-pushed
the
builderror-context-to-stdout
branch
from
308b59d to
84db783
Compare
zackgalbreath
approved these changes
Jan 21, 2026
Collaborator
Author
|
Let's hold off on merging this to let @josephsnyder take a look since it's such a significant change. |
josephsnyder
approved these changes
Jan 26, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
LGTM also. I can't find any immediately obvious issues
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
CDash currently maintains two separate types of build errors: "build errors", which are scraped from the log, and "build failures" which are collected by launchers. Needing (almost) duplicate logic to handle these two cases is a major pain point throughout the codebase. This commit begins the process of merging errors and failures into a single table by migrating the precontext, text, and postcontext columns of the builderror table to a stdoutput column which contains precontext+text+postcontext, and a stderror column which contains just the error text.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDash currently maintains two separate types of build errors: "build errors", which are scraped from the log, and "build failures" which are collected by launchers. Needing (almost) duplicate logic to handle these two cases is a major pain point throughout the codebase. This commit begins the process of merging errors and failures into a single table by migrating the precontext, text, and postcontext columns of the builderror table to a stdoutput column which contains precontext+text+postcontext, and a stderror column which contains just the error text.