Skip to content

Implement Base.isone #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barucden merged 1 commit into from
Mar 5, 2025
Merged

Implement Base.isone #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/decimal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@ Base.signbit(x::Decimal) = x.s
Base.zero(::Type{Decimal}) = Decimal(false, 0, 0)
Base.one(::Type{Decimal}) = Decimal(false, 1, 0)

function Base.isone(x::Decimal)
if signbit(x)
return false
end

if x.q < 0
c, m = cancelfactor(x.c, Val(10), -x.q)
return isone(c) && (m == -x.q)
else
return isone(x.c) && iszero(x.q)
end
end
Base.iszero(x::Decimal) = iszero(x.c)
Base.isfinite(x::Decimal) = true
Base.isnan(x::Decimal) = false
Expand Down
7 changes: 7 additions & 0 deletions test/test_decimal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,14 @@ end

@test isone(one(Decimal))
@test isone(Decimal(0, 1, 0))
@test !isone(Decimal(1, 1, 0))
@test !isone(Decimal(0, 0, 1))
@test !isone(Decimal(0, 1, 1))
@test !isone(Decimal(0, 2, 0))

@test isone(Decimal(0, 1000, -3))
@test !isone(Decimal(0, 1000, -2))
@test !isone(Decimal(0, 1000, -4))

@test isfinite(Decimal(0, 1, 1))
@test !isnan(Decimal(0, 1, 1))
Expand Down
Loading