fix(grid): link vertical grid to ticks on the x axis #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment `<Grid direction={Grid.Direction.VERTICAL}/>` doesn't render anything as it's referring to the points on the Y axis.
This change, updates both `Horizontal` and `Vertical` components so the ticks are based on their axis, but at the same time, respect the `numberOfTicks` property by limiting it to `ticks.length`
JesperLekland
approved these changes
Jun 25, 2020
Owner
JesperLekland
left a comment
JesperLekland
left a comment
There was a problem hiding this comment.
Looks good, I just need to test it before merging 👍
|
ping @zanona @JesperLekland |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
<Grid direction={Grid.Direction.VERTICAL}/>doesn't render anything as it's referring to the points on the Y axis.This change, updates both
HorizontalandVerticalcomponents so the ticks are related to their respective axis, and, at the same time, honours thenumberOfTicksproperty by limiting it toticks.length