Skip to content

Conversation

@matentzn
Copy link
Collaborator

Fixes #87

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a permutations feature to the DOSDP patterns schema, enabling automatic generation of additional annotations by permuting over annotation property values from filler terms. The feature supports generating the cartesian product when multiple permutation entries are specified.

  • Adds a new permutation schema definition with required fields for variable and annotation properties
  • Integrates permutations into both printf_annotation and printf_annotation_obo definitions
  • Provides a test pattern demonstrating the feature usage

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/schema/dosdp_schema.yaml Adds the permutation definition and integrates it into annotation schemas to enable synonym generation through permutations
src/schema/test/positive_test_set/patterns/acute_with_permutations.yaml Provides a test pattern demonstrating the permutations feature for generating synonyms from disease exact_synonym values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Added 'tabulate' and pinned 'jsonschema2md' version in setup.py to fix CI errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: new field for synonym permutations

2 participants