chore: finish up the move to atomic types #3399
Open
+59
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
commented
Dec 2, 2025
Comment on lines
+401
to
+402
| msg.Offset = pc.suppressedHighWaterMarkOffset | ||
| pc.suppressedHighWaterMarkOffset++ |
Contributor
Author
There was a problem hiding this comment.
Rechecked this, and yes, the usage is indeed always made under lock.
puellanivis
commented
Dec 2, 2025
Comment on lines
+381
to
+384
| t *testing.T | ||
| clientID string | ||
| isCapped bool | ||
| sink *testFuncConsumerGroupSink |
Contributor
Author
There was a problem hiding this comment.
These are set at initialisation and never changed after, and thus can be accessed freely without mutex.
Comment on lines
+392
to
+393
| claims map[string]int | ||
| errs []error |
Contributor
Author
There was a problem hiding this comment.
These are the two fields that can update after initialization, and are already correctly protected by mutexes. Their movement to here is just to match convention of putting mutex protected values below the mutex that protects them.
Signed-off-by: Cassondra Foesch <[email protected]>
… at the top Signed-off-by: Cassondra Foesch <[email protected]>
puellanivis
force-pushed
the
chore-finish-up-atomic-usage
branch
from
1269371 to
0c3df26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the change in #3277 and rolls out all atomics usage to using the types, rather than the bare functions.
This already found a few usages that had inconsistently used atomic functions on some values.