[cpp] Marshal String Encodings #12476
Merged
+293
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think this is good to go now, I've reverted the CI change since all tests passed. Only downside is that the hxcpp latest CI is broken like everything else, but it would be failing anyway since this is one of those annoying merge order ones. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was thinking about using the new cpp marshalling stuff to make a better
StringBufimplementation but realised that the string marshalling stuff I added was only really usable in terms of null terminated c string interop, not general string to encoded bytes usage.So this makes it a bit more flexible. New extern types
cpp.encoding.Ascii,cpp.encoding.Utf8, andcpp.encoding.Utf16` have been added to deal with conversions between the various internal string encodings hxcpp uses. Most of this functionality already existed in hxcpp, so it's just making it usable from the haxe side.hxcpp side : HaxeFoundation/hxcpp#1283