Fix #4938:修复OfflineAccountSkinPane页面提示栏和按钮重叠的问题 #5117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#5096 中的问题已修复 |
Glavo
reviewed
Jan 2, 2026
HMCL/src/main/java/org/jackhuang/hmcl/ui/account/OfflineAccountSkinPane.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/account/OfflineAccountSkinPane.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #4938 where the prompt bar and buttons were overlapping in the OfflineAccountSkinPane dialog. The solution adds padding and layout constraints to ensure proper spacing between UI elements.
Key Changes
- Increased bottom padding on GridPane from 0 to 48 pixels to prevent overlap with dialog action buttons
- Added column span and horizontal growth settings to the HintPane for the LITTLE_SKIN case to prevent overlap with UI elements
- Reset padding to original value for the LOCAL_FILE case to avoid unnecessary spacing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCL/src/main/java/org/jackhuang/hmcl/ui/account/OfflineAccountSkinPane.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/account/OfflineAccountSkinPane.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/account/OfflineAccountSkinPane.java
Outdated
Show resolved
Hide resolved
Glavo
approved these changes
Jan 2, 2026
Contributor
|
在英语环境会多一个意义不明空行。 右上角图标看起来很难解决，就不题了。 
|
Contributor
Author
稍等，我确认一下 |
Contributor
Author
我这里无法复现，至于按钮请单开issue，我将尝试修复它 @3gf8jv4dv
|
Contributor
|
@NoClassFoundError 我试了下，似乎和字体有关系。 你可以分别使用 Tahoma 和 Calibri 字体再看下。 |
Contributor
Author
Calibri
Tahoma
|
Contributor
|
@NoClassFoundError 你这个图中，中文 fallback 到宋体上了。用英语看看？ |
Contributor
Author
Calibri
Tahoma
很奇怪，让我研究一下
|
Contributor
Author
|
@3gf8jv4dv 貌似问题已经解决，可以新开issue，我马上会更新我的分支，你可以构建试试 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.