made refine_valid_reflections() function for fitgrains #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
reviewed
Jan 7, 2026
|
|
||
| # make dict to contain new culled results | ||
| culled_results_r = defaultdict(list) | ||
| num_refl_valid = 0 |
Collaborator
There was a problem hiding this comment.
It looks like num_refl_valid isn't being computed anymore, and left at 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This cleans up part of
hedm/fitgrains.py. It replaces inline code with a function for processing valid reflections. it is a simple change, affecting only one file.Affected Workflows
Documentation Changes
This adds the function
determine_valid_reflectionswith docstrings.