Hedm instrument pull_spots refactor

[ZackAttack614]

Overview

This PR cleans up the HEDMInstrument pull_spots function significantly, making it easier to test and work with. This is a part of the effort to simplify the HEXRD library, enabling solid testing and confidence in correctness. On top of the simplifcation of the logic in the method, docstrings and typing were added to make future use of the function easier.

Affected Workflows

Changes should not affect any existing workflows, and are designed to be backwards-compatible.

Documentation Changes

No existing documentation needs to be changed to accommodate this PR.

[codecov]

Codecov Report

❌ Patch coverage is 65.03497% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.96%. Comparing base (5ab82ac) to head (2f85226).
⚠️ Report is 20 commits behind head on master.

Files with missing lines	Patch %	Lines
hexrd/core/instrument/hedm_instrument.py	65.03%	50 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   68.82%   68.96%   +0.14%     
==========================================
  Files         144      145       +1     
  Lines       22090    22264     +174     
==========================================
+ Hits        15203    15355     +152     
- Misses       6887     6909      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[donald-e-boyce]

This looks good.

[ZackAttack614]

Thank you @donald-e-boyce ! I'll merge once we get buy-in from @psavery who plans to test this out with the GUI.