chore: bump sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.0 #2008
Conversation
dependabot
bot
added
dependencies
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/ok-to-test |
Camila-B
force-pushed
the
dependabot/go_modules/sigs.k8s.io/controller-runtime-0.23.0
branch
4 times, most recently
from
ad0d31f to
905d449
Compare
|
/retest |
1 similar comment
|
/retest |
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.22.4 to 0.23.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.22.4...v0.23.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.23.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Camila-B
force-pushed
the
dependabot/go_modules/sigs.k8s.io/controller-runtime-0.23.0
branch
from
905d449 to
74bb48b
Compare
- Fixed `fake.Cache`: Corrected the Start method's locking logic and updated WaitForCacheSync to properly wait for all informers to synchronize using k8scache.WaitForCacheSync. - Implemented `WatchList` Support: Modified MemoryStorage.Watch to support SendInitialEvents by asynchronously sending synthetic ADDED events for existing objects, followed by a Bookmark event with the k8s.io/initial-events-end: true annotation. - Improved Watcher Robustness: Updated Watcher.handleEvents to gracefully handle empty ResourceVersion strings and modified Watcher.sendEvent to allow Bookmark events to bypass list filter validation.
Camila-B
force-pushed
the
dependabot/go_modules/sigs.k8s.io/controller-runtime-0.23.0
branch
from
74bb48b to
463e69b
Compare
| tc.Logger.Debugf("applying %s", kinds.ObjectSummary(obj)) | ||
| AddTestLabel(obj) | ||
| opts = append(opts, client.FieldOwner(FieldManager), client.ForceOwnership) | ||
| //nolint:staticcheck // allow deprecated field for backwards compatibility |
There was a problem hiding this comment.
Is there plan to refactor the Patch function to align with new API?
| // WaitForCacheSync returns true when the cached informers are all synced. | ||
| // Returns false if the context is done first. | ||
| func (c *Cache) WaitForCacheSync(ctx context.Context) bool { | ||
| if !c.waitForStart(ctx) { |
There was a problem hiding this comment.
Is this change necessary with the controller-runtime update or it can be pulled out as a standalone PR?
|
|
||
| // Start the Informer if cache is already started | ||
| if c.started { | ||
| klog.V(5).Infof("starting informer for %s", kinds.GVKToString(gvk)) |
There was a problem hiding this comment.
Why is the log line removed
2 participants
Bumps sigs.k8s.io/controller-runtime from 0.22.4 to 0.23.0.
Release notes
Sourced from sigs.k8s.io/controller-runtime's releases.
... (truncated)
Commits
129853dMerge pull request #3419 from alvaroaleman/limit-cardinality00b8b07🐛 Limit depthWithPriorityMetric cardinality to 2543b0e35✨ Delay reconciliation until handlers sync (#3406)137b9c0Merge pull request #3415 from zach593/pq-bufferc47f9cbUse a buffer to optimize priority queue AddWithOpts performance5de4c4fMerge pull request #3416 from alvaroaleman/twotrees9de69a7🌱 Priorityqueue: Use separate b-trees for ready and non-ready items0c3a910Merge pull request #3408 from zach593/pq-fifo31d30b6fix priority queue ordering when item priority changesa085590Merge pull request #3411 from brito-rafa/issue-3410-expbucket-webhookDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)