Also call configure_connection callback for the initial connection in shallow clones
#2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
approved these changes
Dec 11, 2025
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this oversight, this looks good to me!
I don't think this is tested at all (or anywhere) yet, so I suppose it would be unfair to put this on you now 😅. However, if you have some intuition on how this should be tested, I'd be glad if a PR would come out of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why I was being asked for credentials and why my callback wasn't being called. This bug pretty much breaks injected credentials for shallow clones.