Skip to content

Conversation

@gruebel
Copy link
Contributor

@gruebel gruebel commented Dec 9, 2025

Currently it is not possible to only choose the tar feature in gix-archive, also Format::TarGz was not correctly instantiated and throw an additional error.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix, it's much appreciated.

Unfortunately, I can't merge this without a test that triggers it, ideally in a separate commit and push, so CI can turn green with the fix.

Let's fix the reason this bug was present - the missing test.
Thanks again 🙏.

@gruebel
Copy link
Contributor Author

gruebel commented Dec 10, 2025

@Byron
I checked and actually there is already a test for it, but the problem was the test run for gix-archive were not correctly setup and I fixed in the justfile. I also had to enable the deflate-flate2-zlib-rs feature in zip for the gzip feature, otherwise it complains not having a backend. let me know, if it works for you.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks so much for squelching this long-standing bug :).

@Byron Byron merged commit 7e5c05f into GitoxideLabs:main Dec 11, 2025
28 checks passed
@gruebel gruebel deleted the fix-tar-feat branch December 11, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants