Mark gix_hash::Kind as non_exhaustive
#2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to GitoxideLabs#2218 (which is a rewritten version of GitoxideLabs#2213). It marks `gix_hash::Kind` as `non_exhaustive`. This is a breaking change now, but will prevent further breaking changes whenever we add a new hashing algorithm in the future.
Byron
reviewed
Dec 10, 2025
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot! I am surprised there isn't more breakage, which is good I suppose. Or is it 😅?
| fn hash_to_byte(h: gix_hash::Kind) -> u8 { | ||
| match h { | ||
| gix_hash::Kind::Sha1 => 0, | ||
| _ => unreachable!("BUG: not implemented for hash kind {h}"), |
Member
There was a problem hiding this comment.
It's too bad that it's not possible to allow the lint, instead of adding a fallback. That way, Gitoxide could opt-in to 'breaking' loudly once a new variant is added.
This makes me feel this non_exhaustive feature is really half-baked… why I can't we opt-out 😅?
Contributor
Author
There was a problem hiding this comment.
It certainly tackles the problem from a specific angle. :-) I find it very useful, but as you say, there’s downsides in a monorepo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2218 (which is a rewritten version of #2213). It marks
gix_hash::Kindasnon_exhaustive. This is a breaking change now, but will prevent further breaking changes whenever we add a new hashing algorithm in the future.