-
-
Notifications
You must be signed in to change notification settings - Fork 51
Add AxentHost to providers list #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/data/providers.ts
Outdated
| url: 'https://axenthost.com/', | ||
| description: translate({ | ||
| id: 'providers.provider.axenthost.description', | ||
| message: "Once activated, navigate to the server Variants tab and select GeyserMC. Removing the server files in the Files tab beforehand will be required to make a clean installation of Geyser." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once what is activated? Further, which server files should/will be removed - does installing Geyser using this method remove all Geyser-related files, or will it create a fully fresh server? Please be specific; we're in the process of re-making our providers list and these specifics will matter :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way it is made is you create a vanilla Minecraft server by default. Reinstalling the server doesn't delete the current files for no data loss, so it is recommended to delete the current server files before changing the variant.
I'll rewrite it, let me know if it matches what you expect !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @onebeastchris , any news about this ?
|
Any update ? |
|
After talking about this MR on discord, I changed the description to match the latest information on how to create a Geyser server. |
src/data/providers.ts
Outdated
| url: 'https://axenthost.com/games/minecraft/', | ||
| description: translate({ | ||
| id: 'providers.provider.axenthost.description', | ||
| message: 'Create a default Minecraft server. On the server control panel, navigate to the "Variants" tab and select "GeyserMC". The server will be automatically reinstalled with Geyser instead of Vanilla.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this actually install? a paper+geyser server? Or geyser-standalone?
What should users do if they already have a paper / fabric /... server, all of which Geyser supports?
From our end, we created system properties that allow hosts to set port / IP automatically; maybe those can be useful for you:
https://geysermc.org/wiki/geyser/geyser-command-line-arguments-and-system-properties#configuration-system-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are based on this GeyserMC config :
https://github.com/GeyserMC/pterodactyl-stuff/blob/master/egg-paper--geyser--floodgate.json
The users don't have to do anything else, they can either use a paper / fabric... server, or use the geyser "variant", which installs a server with the previous config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onebeastchris Were you asking here to know what has installed or were you expecting a text change to explicitly specify what was installed ? I don't see this really specified for other hosts in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @onebeastchris
This is nearly 1 year old, can we please do something so this is merged ?
|
Hi @lukeeey Can we please merge this ? This is nearly 1 year old and the text is pretty straightforward now. |
|
@Stallos11 The issue is, while the instructions do give a basic idea, there are a few things that aren't clear. From my own testing I know that:
What's not clear:
From reading your comment above, I'd assume the answer to the above is:
Also, when installing Geyser via the addon tab with a fresh server install I get an unexpected error (but i can install other addons fine) and I can't install Geyser for Fabric as we don't publish it to curseforge and that is all you support, so either we need to publish Geyser to CurseForge or you need to update the description to say that it's not supported. I'd say update the description for now. |
Updated the description for the AxentHost provider to clarify installation steps for GeyserMC.
Updated the installation instructions for GeyserMC on AxentHost.
|
@lukeeey Thank you so much for the detailed answer ! What you've found from your own testing is exactly right. For Fabric, only curseforge has been added to the addons tab, but anyone is still able to add their own plugins through the file manager (as it was always available before the addons page was added). It is just an enhancement of the platform itself to help install plugins/mods easier depending on the selected variant. So it is supported, but not through the in house addons manager. For now, you're right about the errors in the addons manager, it has been identified and we'll look into it. I've updated the text so it tells that it is not supported for now through the addons manager and needs to be manually installed by downloading Geyser through the official Geyser website. (which is why we linked the download page on every addon, in order to ensure that if anything goes wrong when installing it, players can still get to the download page and manually get it). I'll be able to make a new pull request when the addons page problem has been resolved. Thanks again |
|
@Stallos11 The manual install doesn't mention if any specific port settings are required, will the default config work or are you using the command line options to force certain things? |
|
@rtm516 Users can use the "GeyserMC" server variant to make it directly work with the default server port for both bedrock & java players. For manual installs, they can either set an additional port, or for example use options like https://geysermc.org/wiki/geyser/setup/self/modded-servers/#:~:text=If%20you%20enable%20clone%2Dremote,share%20the%20port%20with%20Geyser. Would that information be required in the description in your opinion ? It sounds configuration-specific to the users and is already explained by geyser documentation. |
No description provided.