-
-
Notifications
You must be signed in to change notification settings - Fork 795
Refactor the collision system, various improvements to how collision fixes is handle, more fixes (again). #5836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Revert last change, move everything to a different package, added end portal fix. * Oops. * Fixed lantern collision. * Fixed conduit collision. * Fixed scaffolding collision. * Fixed bell collision and sea pickle collision. * Avoid loop. * oops. * oops x2. * Change comments.
* Revert last change, move everything to a different package, added end portal fix. * Oops. * Fixed lantern collision. * Fixed conduit collision. * Fixed scaffolding collision. * Fixed bell collision and sea pickle collision. * Avoid loop. * oops. * oops x2. * Change comments.
…/GeyserMC/Geyser into movement-translation-improvement
|
I wonder if the collision fix for trap doors fixes #2951? Let me know once this is ready for review & I'll do testing on my end |
Nope it won't since as of now we're doing Edit: Can't reproducible as of latest also. |
|
I don't know what else to check for and add so I guess this PR is ready for review. |
This is my second attempt, since I screw up the last one :) yay! so.
Changes:
correctPosition, since this caused many issues (already discuss in Discord).correctPosition, make it little bit more readable.correctPositionnow no longer return true/false, as in the original code this method always return true.