Add full support for Java ping pong packets #5460
Open
+82
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onebeastchris
approved these changes
Apr 8, 2025
Member
onebeastchris
left a comment
onebeastchris
left a comment
There was a problem hiding this comment.
LGTM; however i'll let other people also review this before merging.
Member
|
This PR needs to be rebased / merge in master due to conflicting changes :( |
SamB440
force-pushed
the
feat/ping-pong-support
branch
2 times, most recently
from
5672a24 to
9de1073
Compare
Contributor
Author
|
Should be fixed |
core/src/main/java/org/geysermc/geyser/translator/protocol/java/JavaPingTranslator.java
Show resolved
Hide resolved
SamB440
force-pushed
the
feat/ping-pong-support
branch
from
9de1073 to
768890a
Compare
SamB440
force-pushed
the
feat/ping-pong-support
branch
from
768890a to
3002f5b
Compare
Member
|
RaphiMC/ViaBedrock@374781a seems to confirm that these are sync (and should be treated as such on Geysers end). Will merge by tomorrow :) |
Camotoy
reviewed
May 17, 2025
...va/org/geysermc/geyser/translator/protocol/bedrock/BedrockNetworkStackLatencyTranslator.java
Show resolved
Hide resolved
Konicai
previously requested changes
Jun 6, 2025
...in/java/org/geysermc/geyser/translator/protocol/bedrock/BedrockContainerCloseTranslator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/geysermc/geyser/translator/protocol/java/JavaKeepAliveTranslator.java
Outdated
Show resolved
Hide resolved
onebeastchris
added
the
Waiting On Response
onebeastchris
added
PR: Feature
This comment has been minimized.
This comment has been minimized.
Member
|
There's unfortunately a merge conflict now - otherwise happy to merge |
oryxel1
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the BedrockNetworkStackLatencyTranslator to add support for pings sent by the server and pongs received from the client.
One thing I'm not sure about is the shouldExecuteInEventLoop. It's important that ping/pongs keep their order. On Java, keep alive's are async and ping/pongs are sync. But on bedrock, NetworkStackLatency seems to be sync and there is no separate packet for keep alives.
Tested with
forward-player-ping: true/falseand everything seems to work.