Implement Hardcore Mode #5216
Implement Hardcore Mode #5216
Conversation
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
onebeastchris
left a comment
onebeastchris
left a comment
There was a problem hiding this comment.
except for this one thing, LGTM - sorry for the longer wait.
| // This is to ensure that you don't get stuck without a respawn screen in hardcore | ||
| if (!entity.isAlive()) { |
There was a problem hiding this comment.
if this is specific to hardcore mode - shouldn't this also check for it?
There was a problem hiding this comment.
This only ever happens if hardcore mode is on afaik, I don't think there is a need for an extra check
I don't think this should be merged for now as on Java if you initially join a world that's not on Hardcore and a proxy sends you to a world that is on Hardcore, this PR doesn't account for that as unfortunately it doesn't seem like it's changable after the StartGamePacket is sent. :/ |
Co-authored-by: rtm516 <[email protected]>
|
What harm is there with this being merged, for the sake of single servers that are hardcore? |
@letsgoawaydev that could be worked around by sending a TransferPacket to the bedrock client while keeping the java connection alive on Geyser. Probably not the best way though, but it is possible. Maybe this could be something for an extension? |
|
We've discussed this idea before. It's not really feasible as we'd need to cache all loaded chunks, all block entities, and all entity data and positions. |
|
maybe it could be a config option but it would be better if it just worked
…On Fri, 6 Jun 2025 at 10:31, Camotoy ***@***.***> wrote:
*Camotoy* left a comment (GeyserMC/Geyser#5216)
<#5216 (comment)>
We've discussed this idea before. It's not really feasible as we'd need to
cache all loaded chunks, all block entities, and all entity data and
positions.
—
Reply to this email directly, view it on GitHub
<#5216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQJSY33GSQMVJUI2EM6VIED3CD4R5AVCNFSM6AAAAABTPM6IBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNBXHA2TSMJTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I agree with what camotoy is saying, but that doesn't stop anyone making it into an extension :) |
|
If a config option were to be added, imo it would ideally not be a boolean, but a tristate, with default being whatever the server specifies (so false for proxies and standalone and whatever is in |
|
My janky-ish solution to avoid this issue would be the following:
|
7 participants
This PR properly translates hardcore mode now that it is available in Bedrock Edition.