Skip to content

Conversation

@beojan
Copy link
Contributor

@beojan beojan commented Jan 8, 2026

Fixes issue #220 by special casing plain char in type_id. It is now considered equivalent to signed char even on ARM platforms where it is actually unsigned.

@beojan
Copy link
Contributor Author

beojan commented Jan 8, 2026

@phlexbot format

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Automatic clang-format fixes pushed (commit d23f1bc).
⚠️ Note: Some issues may require manual review and fixing.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

No automatic cmake-format fixes were necessary.

@beojan beojan requested a review from knoepfel January 8, 2026 19:17
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.76%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   76.25%   76.76%   +0.51%     
==========================================
  Files         124      124              
  Lines        2733     2733              
  Branches      475      475              
==========================================
+ Hits         2084     2098      +14     
+ Misses        452      445       -7     
+ Partials      197      190       -7     
Flag Coverage Δ
unittests 76.76% <ø> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/model/type_id.hpp 92.77% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1168a...d23f1bc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel linked an issue Jan 8, 2026 that may be closed by this pull request
@knoepfel knoepfel merged commit 2d6eaa4 into Framework-R-D:main Jan 8, 2026
35 of 36 checks passed
@beojan beojan deleted the fix-220 branch January 8, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phlex build failure in aarch64 Alma9 container

2 participants