Skip to content

Conversation

@greenc-FNAL
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request applies automated CMake formatting using gersemi to standardize the code style across all CMakeLists.txt files and CMake module files in the project.

Key changes:

  • Consistent indentation (4 spaces) applied throughout all CMake files
  • Multi-line function calls reformatted with arguments on separate lines
  • Closing parentheses moved to their own lines for better readability

Reviewed changes

Copilot reviewed 19 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/utilities/CMakeLists.txt Reformatted closing parentheses placement
test/python/CMakeLists.txt Reformatted function calls with consistent multi-line indentation
test/plugins/CMakeLists.txt Reformatted closing parenthesis
test/mock-workflow/CMakeLists.txt Reformatted target_link_libraries and function definitions
test/memory-checks/CMakeLists.txt Reformatted closing parenthesis
test/max-parallelism/CMakeLists.txt Reformatted configure_file calls with arguments on separate lines
test/form/data_products/CMakeLists.txt Reformatted conditional block indentation
test/form/CMakeLists.txt Reformatted conditional block indentation and closing parentheses
test/demo-giantdata/CMakeLists.txt Reformatted add_library call with sources on separate lines
test/benchmarks/CMakeLists.txt Reformatted foreach loop items to single line and target definitions
test/CMakeLists.txt Reformatted closing parentheses across multiple test definitions
plugins/python/CMakeLists.txt Reformatted function definitions and library declarations
phlex/utilities/CMakeLists.txt Reformatted install command with FILES keyword on separate line
phlex/model/CMakeLists.txt Reformatted install command with FILES keyword on separate line
phlex/metaprogramming/CMakeLists.txt Reformatted install commands with FILES keyword on separate line
phlex/graph/CMakeLists.txt Reformatted install commands with FILES keyword on separate line
phlex/core/CMakeLists.txt Reformatted install commands and conditional statements
phlex/app/CMakeLists.txt Reformatted target_link_libraries with arguments on separate lines
phlex/CMakeLists.txt Reformatted closing parentheses
form/storage/CMakeLists.txt Reformatted add_library with sources on separate lines
form/root_storage/CMakeLists.txt Reformatted add_library and target_link_libraries calls
form/CMakeLists.txt Reformatted conditional block indentation
Modules/private/PhlexTargetUtils.cmake Reformatted all function definitions with consistent indentation
Modules/private/CreateCoverageTargets.cmake Reformatted extensive function with consistent multi-line argument placement
Modules/private/CreateClangTidyTargets.cmake Reformatted option declarations and function definitions
Modules/NProc.cmake Reformatted conditional block indentation
Modules/Findjsonnet.cmake Reformatted execute_process and string operations
CMakeLists.txt Reformatted FetchContent declarations and conditional blocks

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.21%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   76.61%   76.21%   -0.41%     
==========================================
  Files         124      124              
  Lines        2733     2733              
  Branches      475      475              
==========================================
- Hits         2094     2083      -11     
- Misses        446      452       +6     
- Partials      193      198       +5     
Flag Coverage Δ
unittests 76.21% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f0895...40c4ea1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Line length 80 -> 99
- Indent 4 -> 2
@greenc-FNAL greenc-FNAL merged commit d4fbb3f into Framework-R-D:main Jan 8, 2026
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants