Safer product_query construction
#205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knoepfel
changed the title
product_query construction.product_query construction
Member
Author
|
@wlav, this PR should help avoid the problem you ran into. Alas, the default This is not an urgent PR. |
knoepfel
force-pushed
the
safer-product-query-construction
branch
from
f8999e2 to
3bb9231
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 76.61% 76.71% +0.09%
==========================================
Files 124 124
Lines 2733 2727 -6
Branches 475 475
==========================================
- Hits 2094 2092 -2
+ Misses 446 442 -4
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
force-pushed
the
safer-product-query-construction
branch
from
3bb9231 to
274bd88
Compare
Also switch to using default comparisons
knoepfel
force-pushed
the
safer-product-query-construction
branch
from
274bd88 to
16a9c43
Compare
beojan
approved these changes
Jan 9, 2026
|
|
||
| auto const& spec() const noexcept { return spec_; } | ||
| auto const& layer() const noexcept { return layer_; } | ||
| void set_type(experimental::type_id&& type) { spec_.set_type(std::move(type)); } |
Contributor
There was a problem hiding this comment.
Don't need the std::move here, it's already an rvalue reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either default-construct
product_queryor require the constructor with both theproduct_specificationand thelayerargument.Also switch to using default comparisons