Skip to content

Add Thumbnail to Media Group #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-yarzebinski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Thumbnail to Media Group #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/domain/media/group.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import 'package:dart_rss/domain/media/rating.dart';
import 'package:dart_rss/util/helpers.dart';
import 'package:xml/xml.dart';

import 'thumbnail.dart';

class Group {
static Group? parse(XmlElement? element) {
if (element == null) {
Expand All @@ -14,6 +16,7 @@ class Group {
return Group(
contents: element.findElements('media:content').map((e) => Content.parse(e)).toList(),
credits: element.findElements('media:credit').map((e) => Credit.parse(e)).toList(),
thumbnails: element.findElements('media:thumbnail').map((e) => Thumbnail.parse(e)).toList(),
category: Category.parse(findElementOrNull(element, 'media:category')),
rating: Rating.parse(findElementOrNull(element, 'media:rating')),
);
Expand All @@ -22,12 +25,14 @@ class Group {
const Group({
this.contents = const <Content>[],
this.credits = const <Credit>[],
this.thumbnails = const <Thumbnail>[],
this.category,
this.rating,
});

final List<Content> contents;
final List<Credit> credits;
final List<Thumbnail> thumbnails;
final Category? category;
final Rating? rating;
}
6 changes: 6 additions & 0 deletions test/atom_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,12 @@ void main() {
expect(item.media!.group!.category!.value, 'music/artist name/album/song');
expect(item.media!.group!.rating!.value, 'nonadult');

final mediaGroupThumbnail = item.media!.group!.thumbnails.first;
expect(mediaGroupThumbnail.url, 'http://www.foo.com/keyframe1.jpg');
expect(mediaGroupThumbnail.width, '75');
expect(mediaGroupThumbnail.height, '50');
expect(mediaGroupThumbnail.time, '12:05:01.123');

expect(item.media!.contents.length, 2);
final mediaContent = item.media!.contents.first;
expect(mediaContent.url, 'http://www.foo.com/video.mov');
Expand Down
1 change: 1 addition & 0 deletions test/xml/Atom-Media.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
<media:credit role="musician">band member 2</media:credit>
<media:category>music/artist name/album/song</media:category>
<media:rating>nonadult</media:rating>
<media:thumbnail url="http://www.foo.com/keyframe1.jpg" width="75" height="50" time="12:05:01.123" />
</media:group>
<media:title type="plain">The Judy's -- The Moo Song</media:title>
<media:description type="plain">This was some really bizarre band I listened to as a young lad.</media:description>
Expand Down