Skip to content

Conversation

@rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 20, 2025

Closes: #224

This PR removes theEXTRA_DATA_MAX_SIZE limit on extraData across all PDPVerifier functions, implementing option 1 from the discussion in #224.

Background

The current 2KB limit is insufficient for handling multiple pieces and KVs (Key-Values). After discussion in the daily sync, we aligned on removing the limit entirely since:

  1. This limit is a concern for Curio & service contracts
  2. There's no technical reason for PDPVerifier to enforce an arbitrary cap

fix: update `EXTRA_DATA_MAX_SIZE` limit
@FilOzzy FilOzzy added this to FS Oct 20, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Oct 20, 2025
chore: remove `EXTRA_DATA_MAX_SIZE` limit
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FS Oct 20, 2025
@rjan90 rjan90 requested a review from Kubuxu October 20, 2025 11:23
@rjan90 rjan90 changed the title fix: update EXTRA_DATA_MAX_SIZE limit fix: remove EXTRA_DATA_MAX_SIZE limit Oct 20, 2025
@rjan90 rjan90 requested a review from rvagg October 20, 2025 11:23
@rjan90 rjan90 moved this to 🔎 Awaiting review in PDP Oct 20, 2025
@rjan90 rjan90 marked this pull request as ready for review October 20, 2025 11:23
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FS Oct 20, 2025
@rjan90 rjan90 merged commit 895b6f1 into main Oct 20, 2025
3 checks passed
@rjan90 rjan90 deleted the phi/increase-max-data-size branch October 20, 2025 11:32
@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to 🎉 Done in PDP Oct 20, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FS Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done
Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Increase PDP Extradata Size Limit from 2KB

3 participants