bgpd: Additional commits for graceful restart #20239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pdoijode
force-pushed
the
pdoijode/remaining-gr-commits
branch
from
76f9b80 to
d79eadc
Compare
ton31337
reviewed
Dec 10, 2025
| if (peer_immediate_announce(peer, paf->afi, paf->safi)) { | ||
| update_subgroup_split_peer(paf, updgrp); | ||
| subgrp = paf->subgroup; | ||
| subgrp->v_coalesce = 0; |
Member
There was a problem hiding this comment.
Shouldn't we stop subgrp->t_coalesce (in case this is very large and running yet)?
ton31337
reviewed
Dec 10, 2025
bgpd/bgpd.c
Outdated
|
|
||
| bgp_peer_gr_flags_update(peer); | ||
| /* Initialize per peer bgp GR FSM */ | ||
| bgp_peer_gr_init(peer); |
Member
There was a problem hiding this comment.
Is this commit really part of the coalesce timer foobar?
Contributor
Author
There was a problem hiding this comment.
This is separate commit, related to GR. All commits in this MR are improvements in GR
ton31337
reviewed
Dec 10, 2025
bgpd/bgp_updgrp.c
Outdated
| if (old_subgrp) { | ||
| /* | ||
| * If we need to announce immediately, put peer in its | ||
| * own group and set its coalsece timer to 0. |
ton31337
reviewed
Dec 10, 2025
donaldsharp
reviewed
Dec 10, 2025
bgpd/bgp_route.c
Outdated
| bgp_zebra_route_install(dest, new_select, bgp, true, | ||
| NULL, false); | ||
| if (CHECK_FLAG(bgp->gr_info[afi][safi].flags, BGP_GR_SKIP_BP)) | ||
| bgp_zebra_announce_actual(dest, old_select, bgp); |
Member
There was a problem hiding this comment.
Is this correct? Install the old_select?
When acting as a Helper router for a Restarting router, skip running the coalesce timer after the peering comes up, but immediately announce the routes. This is to facilitate the Restarting router immediately get the latest set of routes and start its path selection. Likewise, skip an extra run of the coalesce timer on the Restarting router. Routes will only be announced after deferred path selection. Signed-off-by: Vivek Venkatraman <[email protected]>
Pdoijode
force-pushed
the
pdoijode/remaining-gr-commits
branch
from
d79eadc to
f48118a
Compare
Pdoijode
changed the title
when the bgp warmboot is trigerred, all the subgroups from the peer paf are deleted. but the corresponding router annouce timer are not stopped. If this timer get scheduled in mean time, we see the crash. Fix: stop timer before clearing the subgoup from paf. Signed-off-by: Vijayalaxmi Basavaraj <[email protected]>
Decoupling GR and backpressure i.e. in case GR is kicked in, the deferred best path selection will continue its normal flow of BGP installing/uninstalling routes directly into zebra rather than applying backpressure logic of processing it later. Signed-off-by: Rajasekar Raja <[email protected]>
Pdoijode
force-pushed
the
pdoijode/remaining-gr-commits
branch
from
f48118a to
2da9f0f
Compare
ton31337
reviewed
Dec 12, 2025
| bool route_sync; | ||
| bool select_defer_over; | ||
| uint8_t flags; | ||
| #define BGP_GR_SKIP_BP (1 << 0) |
Member
There was a problem hiding this comment.
What does it mean (extended version)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to individual commits