-
-
Notifications
You must be signed in to change notification settings - Fork 13
Implement Ecreee e-tender plugin integration #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dmohns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @93Kamuran
Thanks for the PR!
Could you please add usage guide documentation to this PR? I.e. what steps do users have to do to enable this integration on their account. The integration seems quite similar to Odyssey, you can check it's docs for a reference: https://micropowermanager.io/usage-guide/odyssey-integration.html
It looks like users need to generate a token and upload it to ECREEE platform? It would be great if you can clarify this as part of the documentation
| public function getMeterData(?string $startDate, ?string $endDate): Collection { | ||
| return $this->tokenService->getTokensInRange($startDate, $endDate); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this is what exposes the data to ECREEE. Is it correct that we expose Tokens here? What about SmartMeters that don't have tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MPM generates custom tokens for smart meters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MPM generates custom tokens for smart meters.
I see. I wasn't aware of this behaviour. Out of curiosity, can you link me to the code piece where this happens?
src/backend/packages/inensus/ecreee-e-tender/src/Services/EcreeeTokenService.php
Outdated
Show resolved
Hide resolved
.../packages/inensus/ecreee-e-tender/database/migrations/create_ecreee_e_tender_tables.php.stub
Outdated
Show resolved
Hide resolved
dmohns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot
closes #1185