Skip to content

Conversation

@93Kamuran
Copy link
Contributor

closes #1185

Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @93Kamuran

Thanks for the PR!

Could you please add usage guide documentation to this PR? I.e. what steps do users have to do to enable this integration on their account. The integration seems quite similar to Odyssey, you can check it's docs for a reference: https://micropowermanager.io/usage-guide/odyssey-integration.html

It looks like users need to generate a token and upload it to ECREEE platform? It would be great if you can clarify this as part of the documentation

Comment on lines 17 to 19
public function getMeterData(?string $startDate, ?string $endDate): Collection {
return $this->tokenService->getTokensInRange($startDate, $endDate);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this is what exposes the data to ECREEE. Is it correct that we expose Tokens here? What about SmartMeters that don't have tokens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPM generates custom tokens for smart meters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPM generates custom tokens for smart meters.

I see. I wasn't aware of this behaviour. Out of curiosity, can you link me to the code piece where this happens?

@93Kamuran 93Kamuran requested a review from dmohns December 17, 2025 07:34
Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot

@dmohns dmohns merged commit 1b84321 into main Jan 6, 2026
16 checks passed
@dmohns dmohns deleted the ecreee-e-tender branch January 6, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Ecreee e-tender platform plugin

4 participants