chore Clean-up references to FedexMailviewAccount #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Decommission `FedexMailviewAccount`. Cleaning up trace elements. Release Test Plan: TBD Reviewers: #team-fedex, #oss-group! Tags: #no_risk_assessed Differential Revision: https://phab.easypo.net/D65687
Justintime50
requested changes
Jul 21, 2025
Member
Justintime50
left a comment
Justintime50
left a comment
There was a problem hiding this comment.
We autogenerate these curl commands based on whatever is available via the /carrier_types endpoint from the API (I believe this was done so in the last ~3 months). Its existence here means it's probably still returning from that endpoint. We'd want it remove there before we remove it here, otherwise it'll just get re-introduced at some point when we regenerate these files. If it's been removed from that endpoint, I'm all for removing it here.
Contributor
Author
$ ep_curl easypost-prod /v2/carrier_types | jq '.[].type' -r | grep Fed
FedexAccount
FedexCrossBorderAccount
FedexSmartpostAccount
$It was changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrier account type
FedexMailviewAccounthas been deprecated for over a year. Cleaning up example create script.