fix: StatelessRateDeserializer and WebhookDeserializer for underscore fields #370
+91
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The removal of the serialized name fields was intentional in a previous PR; however, it was based on an assumption that the StatelessRate model should work like the rest of the models in this library. TLDR: The deserializer for that model did not properly map underscored JSON fields correctly which is why once removed the behavior exhibited like it did. The fix is to not return the serialized name fields but instead correct the StatelessRateDeserializer to work as expected. This bug report also surfaced that the WebhookDeserializer had the same issue and will be corrected as a part of this.
Testing
A/B tested with and without the fix, updated unit tests to protect against regressions
Pull Request Type
Please select the option(s) that are relevant to this PR.