Oversaturation #3683
Open
Oversaturation #3683
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwieder
added
next
Contributor
|
Thanks for opening this PR, Sean. Have you done any scientific tests of the code or can you describe expected behavior / answer changes? Would a short SP run be enough to quantify differences? Are we safer doing a BGC run to see if there are C cycle changes? Fixes part two listed in #3679 |
Member
|
CTSM SE meeting 2026-01-08: @wwieder will do some scientific testing. |
samsrabin
requested changes
Jan 8, 2026
| over_saturation = max(h2osoi_liq(c,j)-(eff_porosity(c,j)*m_to_mm*dz(c,j)),0._r8) | ||
| h2osoi_liq(c,j) = min(eff_porosity(c,j)*m_to_mm*dz(c,j), h2osoi_liq(c,j)) | ||
| h2osoi_liq(c,j-1) = h2osoi_liq(c,j-1) + over_saturation | ||
| end do |
Member
There was a problem hiding this comment.
@wwieder says this is already happening somewhere else. Let's convert to a function that can be reused.
samsrabin
removed
the
next
Contributor
|
I'm running a 30 year BCG-Crop case from my:
The case directory is: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a correction for oversaturated soil layers immediately after the soil water flux calculation in SoilWaterMovementMod.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
Any User Interface Changes (namelist or namelist defaults changes)?
Does this create a need to change or add documentation? Did you do so?
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).