-
Notifications
You must be signed in to change notification settings - Fork 2
openEO example #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openEO example #13
Conversation
|
edobrowolska
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JanssenBrm Thank you for your work on these examples tutorials! I think they look great! I just left few comments/updates before merging, so please have a look. Also I think this is very nice set of notebooks to put into Getting started notebook and enrich the documentation. :) The publication part can also be referenced in the tutorials as a part of platform-specific publication tools. Thanks again!
JanssenBrm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @edobrowolska for this thorough review. Your feedback is greatly appreciated and very valuable. Your comments are absolutely valid and should now be addressed with the latest commit.
|
Just a few things from me:
Thanks for the detailed examples |
update index examples PRR
Update the starting examples page
update the description
|
Thank you, @edobrowolska, for the additional feedback. I have added the necessary links in the other pages. Let me know if this PR can be merged into the main branch or if there are other things we should adapt before doing so. |
edobrowolska
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JanssenBrm from my side it's fine to merge. Thank you for addressing my comments it looks great! :)
Added an openEO e2e example where we explain the following steps: