TimeView: Improve types #32093
Merged
TimeView: Improve types #32093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-farkhutdinov
force-pushed
the
26_1_time_view_types
branch
from
1bebed9 to
6d4e7c1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances TypeScript type safety in the TimeView component by adding explicit type annotations to functions, parameters, callbacks, and class members. The changes focus on improving type definitions without altering functionality.
Key changes:
- Converted function declarations to arrow functions with explicit type signatures
- Added type annotations to method parameters and return types
- Improved interface definitions with proper use of
Omitutility type - Enhanced callback type safety with explicit parameter types
Co-authored-by: Copilot <[email protected]> Signed-off-by: Ruslan Farkhutdinov <[email protected]>
marker-dao
previously approved these changes
Jan 7, 2026
marker-dao
approved these changes
Jan 8, 2026
r-farkhutdinov
added a commit
to r-farkhutdinov/DevExtreme
that referenced
this pull request
Jan 8, 2026
Signed-off-by: Ruslan Farkhutdinov <[email protected]> Co-authored-by: Ruslan Farkhutdinov <[email protected]> Co-authored-by: Copilot <[email protected]>
r-farkhutdinov
added a commit
that referenced
this pull request
Jan 8, 2026
Signed-off-by: Ruslan Farkhutdinov <[email protected]> Co-authored-by: Ruslan Farkhutdinov <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.