Skip to content

Conversation

@tedkahwaji
Copy link
Collaborator

@tedkahwaji tedkahwaji commented Nov 23, 2025

Summary

The following change adds support for including additional roles and APIs to the service account created during the integration quick-start flow. This is intended for downstream products that require permissions beyond those needed for the baseline GCP integration. The UI will maintain the mapping of downstream productID → required APIs and roles. While this mapping will eventually be retrieved via an API, it is currently hard-coded.

I made the decision to send this data during user selection rather than embedding a static mapping in the script. Since the UI already needs this mapping for the Terraform flow, keeping it in one place avoids the need to continually synchronize the script and the UI.

Also when implementing the log forwarding script, the gcloud command was updated to support a builder component that constructs the required arguments for the command. This change updates all usages of the gcloud function to use these builders.

Testing

Tested by updating the UI locally to provide the necessary product requirements for llm-observability and running the script locally

https://drive.google.com/file/d/1inZM0vt7hVUbk9j8_gixuwnF5kKy9-q4/view?usp=sharing

@tedkahwaji tedkahwaji force-pushed the teddy.kahwaji/gcp-3125 branch from 4096df0 to 6ef4116 Compare November 24, 2025 13:56
@tedkahwaji tedkahwaji marked this pull request as ready for review November 24, 2025 13:56
@tedkahwaji tedkahwaji requested a review from a team as a code owner November 24, 2025 13:56
@tedkahwaji tedkahwaji requested review from thekevinhuang and removed request for a team November 24, 2025 13:56
@tedkahwaji tedkahwaji force-pushed the teddy.kahwaji/gcp-3125 branch from 6ef4116 to 6a4fcec Compare November 24, 2025 14:31
@dtru-ddog dtru-ddog self-requested a review November 25, 2025 15:13
@tedkahwaji tedkahwaji force-pushed the teddy.kahwaji/gcp-3125 branch from 6a4fcec to 877e939 Compare December 2, 2025 00:28
Copy link

@thekevinhuang thekevinhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. Did want to note that this does put the onus on the downstream product team to supply the correct api/permissions (and the eventual code reviewer to confirm that those do exist).

@tedkahwaji tedkahwaji force-pushed the teddy.kahwaji/gcp-3125 branch from 0329774 to 34dc45f Compare December 8, 2025 13:00
@tedkahwaji tedkahwaji merged commit 0a9d284 into main Dec 8, 2025
1 check passed
@tedkahwaji tedkahwaji deleted the teddy.kahwaji/gcp-3125 branch December 8, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants