-
Notifications
You must be signed in to change notification settings - Fork 469
chore(profiling): fix 'test_semaphore_and_bounded_semaphore_collectors_coexist' test #15536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profiling): fix 'test_semaphore_and_bounded_semaphore_collectors_coexist' test #15536
Conversation
|
|
…s_coexist' test in Lock Profiler
dcbc89e to
54a0c53
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 250 ± 4 ms. The average import time from base is: 251 ± 4 ms. The import time difference between this PR and base is: -0.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate vlad/lockprof-fix-test_semaphore_and_bounded_semaphore_collectors_coexist (54a0c53) with baseline main (ca3c521) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.5% Memory: ✅ 40.133MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.8% Memory: ✅ 40.164MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ add_inplace_noaspectTime: ✅ 0.322µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.6% Memory: ✅ 40.371MB (SLO: <41.500MB -2.7%) vs baseline: +5.1% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.5% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +3.7% ✅ bytearray_aspectTime: ✅ 1.360µs (SLO: <10.000µs 📉 -86.4%) vs baseline: ~same Memory: ✅ 40.252MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.489µs (SLO: <10.000µs 📉 -85.1%) vs baseline: -1.3% Memory: ✅ 40.135MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ bytearray_extend_noaspectTime: ✅ 0.611µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -1.1% Memory: ✅ 40.230MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ bytearray_noaspectTime: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.5% Memory: ✅ 40.191MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ bytes_aspectTime: ✅ 1.302µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.4% Memory: ✅ 40.113MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.6% Memory: ✅ 40.156MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 1.350µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.7% Memory: ✅ 40.091MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ bytesio_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.8% Memory: ✅ 40.093MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ capitalize_aspectTime: ✅ 0.733µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.9% Memory: ✅ 40.192MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +2.1% Memory: ✅ 40.211MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ casefold_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.7%) vs baseline: ~same Memory: ✅ 40.194MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.1% Memory: ✅ 40.155MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.727µs (SLO: <10.000µs 📉 -92.7%) vs baseline: ~same Memory: ✅ 40.253MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ decode_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.8% Memory: ✅ 40.212MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.1% Memory: ✅ 40.172MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.1% Memory: ✅ 40.074MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ format_aspectTime: ✅ 3.384µs (SLO: <10.000µs 📉 -66.2%) vs baseline: -1.6% Memory: ✅ 40.174MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ format_map_aspectTime: ✅ 3.532µs (SLO: <10.000µs 📉 -64.7%) vs baseline: -0.8% Memory: ✅ 40.208MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 0.770µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.7% Memory: ✅ 40.152MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.7% Memory: ✅ 40.057MB (SLO: <41.500MB -3.5%) vs baseline: +4.3% ✅ index_aspectTime: ✅ 0.352µs (SLO: <10.000µs 📉 -96.5%) vs baseline: -1.9% Memory: ✅ 40.213MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.4% Memory: ✅ 40.295MB (SLO: <41.500MB -2.9%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.4% Memory: ✅ 40.293MB (SLO: <41.500MB -2.9%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +4.2% ✅ ljust_aspectTime: ✅ 2.595µs (SLO: <20.000µs 📉 -87.0%) vs baseline: +2.2% Memory: ✅ 40.294MB (SLO: <41.500MB -2.9%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.3% Memory: ✅ 40.272MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ lower_aspectTime: ✅ 2.303µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +3.0% Memory: ✅ 40.213MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 40.253MB (SLO: <41.500MB -3.0%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 2.254µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.8% Memory: ✅ 40.195MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.7% Memory: ✅ 40.254MB (SLO: <41.500MB -3.0%) vs baseline: +5.1% ✅ modulo_aspectTime: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +3.7% Memory: ✅ 40.353MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.554µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.2% Memory: ✅ 40.174MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ modulo_aspect_for_bytesTime: ✅ 0.983µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.8% Memory: ✅ 40.275MB (SLO: <41.500MB -3.0%) vs baseline: +5.2% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.238µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +1.2% Memory: ✅ 40.156MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.625µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -0.8% Memory: ✅ 40.214MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 4.880µs (SLO: <10.000µs 📉 -51.2%) vs baseline: -1.1% Memory: ✅ 40.173MB (SLO: <41.500MB -3.2%) vs baseline: +4.0% ✅ replace_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 40.275MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ repr_aspectTime: ✅ 0.901µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.3% Memory: ✅ 40.111MB (SLO: <41.500MB -3.3%) vs baseline: +4.2% ✅ repr_noaspectTime: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 40.230MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ rstrip_aspectTime: ✅ 1.940µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +0.5% Memory: ✅ 40.215MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.7% Memory: ✅ 40.135MB (SLO: <41.500MB -3.3%) vs baseline: +4.3% ✅ slice_aspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 40.152MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.450µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.9% Memory: ✅ 40.214MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 1.531µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -0.2% Memory: ✅ 40.273MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 0.711µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.4% Memory: ✅ 40.231MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 2.218µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.4% Memory: ✅ 40.113MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ strip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.2% Memory: ✅ 40.095MB (SLO: <41.500MB -3.4%) vs baseline: +4.2% ✅ swapcase_aspectTime: ✅ 2.811µs (SLO: <10.000µs 📉 -71.9%) vs baseline: 📈 +14.5% Memory: ✅ 40.014MB (SLO: <41.500MB -3.6%) vs baseline: +3.9% ✅ swapcase_noaspectTime: ✅ 0.534µs (SLO: <10.000µs 📉 -94.7%) vs baseline: +0.3% Memory: ✅ 40.213MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.440µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +2.6% Memory: ✅ 40.174MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.5% Memory: ✅ 40.055MB (SLO: <41.500MB -3.5%) vs baseline: +4.2% ✅ translate_aspectTime: ✅ 3.324µs (SLO: <10.000µs 📉 -66.8%) vs baseline: +1.0% Memory: ✅ 40.193MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 1.045µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +0.5% Memory: ✅ 40.332MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ upper_aspectTime: ✅ 2.334µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +3.3% Memory: ✅ 40.173MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ upper_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 40.196MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.131µs (SLO: <10.000µs 📉 -48.7%) vs baseline: 📈 +24.6% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.4% ✅ ospathbasename_noaspectTime: ✅ 1.083µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -1.1% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 6.136µs (SLO: <10.000µs 📉 -38.6%) vs baseline: +0.1% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.293µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.1% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.4% ✅ ospathnormcase_aspectTime: ✅ 3.463µs (SLO: <10.000µs 📉 -65.4%) vs baseline: +0.7% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.576µs (SLO: <10.000µs 📉 -94.2%) vs baseline: -1.4% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.2% ✅ ospathsplit_aspectTime: ✅ 4.758µs (SLO: <10.000µs 📉 -52.4%) vs baseline: +0.4% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.595µs (SLO: <10.000µs 📉 -84.1%) vs baseline: ~same Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.651µs (SLO: <10.000µs 📉 -63.5%) vs baseline: -0.2% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathsplitdrive_noaspectTime: ✅ 0.694µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.7% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.489µs (SLO: <10.000µs 📉 -55.1%) vs baseline: -0.2% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.388µs (SLO: <10.000µs 📉 -86.1%) vs baseline: -0.6% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.384µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +14.4% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 202.234µs (SLO: <220.000µs -8.1%) vs baseline: +0.6% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.309µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.1% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.829µs (SLO: <230.000µs -6.2%) vs baseline: -0.7% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.175µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.029µs (SLO: <150.000µs -9.3%) vs baseline: +0.4% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.059µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -0.4% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 213.736µs (SLO: <250.000µs 📉 -14.5%) vs baseline: -0.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.357ms (SLO: <22.000ms -7.5%) vs baseline: ~same Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.296ms (SLO: <2.550ms -10.0%) vs baseline: -0.7% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.5% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.405ms (SLO: <1.550ms -9.3%) vs baseline: +0.6% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.209ms (SLO: <2.550ms 📉 -13.4%) vs baseline: -0.5% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.657µs (SLO: <20.000µs 📉 -76.7%) vs baseline: -0.7% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.2% ✅ flush-100-metricsTime: ✅ 175.365µs (SLO: <250.000µs 📉 -29.9%) vs baseline: ~same Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.188ms (SLO: <2.500ms 📉 -12.5%) vs baseline: +0.4% Memory: ✅ 35.920MB (SLO: <36.500MB 🟡 -1.6%) vs baseline: +5.0% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Fix a segfault in the test_semaphore_and_bounded_semaphore_collectors_coexist test that occurred on Python 3.12. The test was missing the required ddup.config() and ddup.start() initialization before using lock collectors.
This test was introduced in #15375 (unsure how it passed there...), but it should be working now.
What Happened
The test used
ThreadingSemaphoreCollectorandThreadingBoundedSemaphoreCollectorwithout initializing the ddup module first. When the profiler tried to push sample data via handle.push_acquire(), it crashed with a segfault because the C extension's internal state (memory buffers, output file handles) was uninitialized.Changes
Testing