Skip to content

Conversation

@crysmags
Copy link
Collaborator

What does this PR do?

This is to add support for Google's GenAi

@sabrenner sabrenner self-assigned this Nov 17, 2025
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Overall package size

Self size: 13.52 MB
Deduped: 113.71 MB
No deduping: 128.73 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.3 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 66.99507% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.79%. Comparing base (0bb1f17) to head (2bcab5a).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/llmobs/plugins/genai/util.js 60.92% 59 Missing ⚠️
...ackages/dd-trace/src/llmobs/plugins/genai/index.js 91.48% 4 Missing ⚠️
...ages/dd-trace/src/service-naming/schemas/v0/web.js 0.00% 2 Missing ⚠️
...ages/datadog-instrumentations/src/helpers/hooks.js 0.00% 1 Missing ⚠️
packages/dd-trace/src/plugins/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6933      +/-   ##
==========================================
- Coverage   84.94%   84.79%   -0.15%     
==========================================
  Files         514      516       +2     
  Lines       21754    21991     +237     
==========================================
+ Hits        18478    18648     +170     
- Misses       3276     3343      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2025

Benchmarks

Benchmark execution time: 2025-12-05 15:48:16

Comparing candidate commit 2bcab5a in PR branch crysmags/gemini-rebase with baseline commit 0bb1f17 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 294 metrics, 26 unstable metrics.

Copy link
Collaborator

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just gave it an initial pass, and mostly just cleanup comments plus a couple of questions!

one thing for file hierarchy that might help with the readability of the llm observability genai plugin is if we split it into two files - so making it a genai folder instead of genai.js, and then having index.js with the GenAiLLMObsPlugin class, and a utils.js for all the private utility functions that are currently in the class that don't rely on this. That way, the GenAiLLMObsPlugin is just calling the helper functions and using their outputs with the tagger. wdyt?

if that sounds good i think we have a similar scenario for the ai plugin: https://github.com/DataDog/dd-trace-js/tree/master/packages/dd-trace/src/llmobs/plugins/ai

@crysmags crysmags force-pushed the crysmags/gemini-rebase branch from 7e70820 to c1453fb Compare November 20, 2025 14:47
@datadog-datadog-prod-us1

This comment has been minimized.

@crysmags crysmags force-pushed the crysmags/gemini-rebase branch from 0323c23 to c596e06 Compare December 3, 2025 15:12
Copy link
Collaborator

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me just some last couple cleanup comments/making some things constants at the top of files. otherwise good to approve after!

Copy link
Collaborator

@sabrenner sabrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@crysmags crysmags marked this pull request as ready for review December 5, 2025 16:10
@crysmags crysmags requested review from a team as code owners December 5, 2025 16:10
@crysmags crysmags requested a review from a team as a code owner December 5, 2025 16:10
@crysmags crysmags merged commit 114188a into master Dec 5, 2025
787 checks passed
@crysmags crysmags deleted the crysmags/gemini-rebase branch December 5, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants